[Webkit-unassigned] [Bug 130664] [CSS Blending] Compositing requirements for blending are not computed correctly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130664





--- Comment #4 from Mihnea Ovidenie <mihnea at adobe.com>  2014-03-31 10:34:02 PST ---
(From update of attachment 228178)
View in context: https://bugs.webkit.org/attachment.cgi?id=228178&action=review

> Source/WebCore/ChangeLog:13
> +        being the closest stacking context should be accelerated as well.

Probably this can be rewritten: "if a layer having blend mode is composited, its closest stacking context ancestor should be composited as well"

> Source/WebCore/ChangeLog:23
> +        * rendering/RenderLayerCompositor.cpp:

You should mention something about the renaming of m_subtreeHasBlending => m_hasUnisolatedCompositedBlendingDescendants in CompositingState.

> Source/WebCore/rendering/RenderLayer.h:789
> +    bool isolatesCompositedBlending() const

In general, i would like to see as much as possible code related to this feature guarded by ENABLE(CSS_COMPOSITING)

> Source/WebCore/rendering/RenderLayerCompositor.cpp:-208
> -        , m_subtreeHasBlending(other.m_subtreeHasBlending)

Maybe you can make these bool bit fields in a follow up patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.