[Webkit-unassigned] [Bug 130922] [CSS Blending] showLayerTree should dump layer's blend mode and isolation properties

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130922





--- Comment #3 from Mihnea Ovidenie <mihnea at adobe.com>  2014-03-31 08:14:24 PST ---
(From update of attachment 228159)
View in context: https://bugs.webkit.org/attachment.cgi?id=228159&action=review

You have to get Simon's or Dean's review on this but i will give you my opinion, hopefully it is valuable.

> Source/WebCore/rendering/RenderLayer.h:789
> +    BlendMode blendMode() const

I think we should wrap everything in CSS_COMPOSITING unless it is really important to have functions that work also when CSS_COMPOSITING is not enabled.

> Source/WebCore/rendering/RenderTreeAsText.cpp:631
> +    if (l.hasBlendMode())

I would use ENABLE(CSS_COMPOSITING) to guard this code. In addition to that, i would simply output "isolatesBlending" instead of "isolation" when a layer does this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.