[Webkit-unassigned] [Bug 129970] AX: Trailing semicolon in Tools/DumpRenderTree/AccessibilityUIElement.cpp since bug 129039

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 29 15:35:58 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=129970





--- Comment #9 from Landry Breuil <landry at openbsd.org>  2014-03-29 15:36:17 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > That's the main problem for feeding back patches to webkit, one has to upload it first, get it reviewed, manually add the reviewed by line, reupload it, and then get someone to mark it cq+ to get it commited by the commit bot. The tools are not smart enough to do this by themselves.... :( Way too cumbersome.
> 
> You don't have to manually add the reviewed by line. If you leave in the Reviewed By OOPS line, the CQ will auto fix that for you. However if you delete that line, you'll get failures like this

Hah, thanks for pointing that out, wasnt obvious. i'll try to keep it in mind for next patches.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list