[Webkit-unassigned] [Bug 130746] WebProcesses use lots of cpu in the background if there are a lot of plugins.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130746


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #227980|review?                     |review+
               Flag|                            |




--- Comment #4 from Anders Carlsson <andersca at apple.com>  2014-03-28 14:29:18 PST ---
(From update of attachment 227980)
View in context: https://bugs.webkit.org/attachment.cgi?id=227980&action=review

> Source/WebKit2/PluginProcess/PluginProcess.cpp:264
> +    for (auto it = m_webProcessConnections.begin(), end = m_webProcessConnections.end(); it != end; ++it) {
> +        WebProcessConnection* connection = it->get();
> +        connection->audioHardwareDidBecomeActive();
> +    }

This can use range for.

> Source/WebKit2/PluginProcess/PluginProcess.cpp:272
> +    for (auto it = m_webProcessConnections.begin(), end = m_webProcessConnections.end(); it != end; ++it) {
> +        WebProcessConnection* connection = it->get();
> +        connection->audioHardwareDidBecomeInactive();
> +    }

Ditto.

> Source/WebKit2/PluginProcess/PluginProcess.h:45
> +    public WebCore::AudioHardwareListener::Client

Please put this on the same line. I also don't think it needs to be public.

> Source/WebKit2/PluginProcess/PluginProcess.h:102
> +    //AudioHardwareListenerClient

Missing space after //.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.