[Webkit-unassigned] [Bug 130745] webkit-patch upload should complain if bug parameter doesn't match bug in Changelog

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130745





--- Comment #4 from László Langó <llango.u-szeged at partner.samsung.com>  2014-03-28 07:49:54 PST ---
(In reply to comment #3)
> (In reply to comment #1)
> > Just out of curiosity, why did you pass -b parameter to webkit-patch?
> > It parses the bug id from changelog and upload the patch to the proper bug.
> 
> Err, not -b, but just putting the bug number on the command line.
> It's not obvious that the default behavior will parse the change log:
> 
> "upload uploads the current diff to bugs.webkit.org.
>     If no bug id is provided, upload will create a bug.
>     If the current diff does not have a ChangeLog, upload
>     will prepare a ChangeLog."
> 
> That first line from the help message makes it sound like it will unconditionally open a new bug. Does it?

It does, if no bugurl in the ChangeLog and neither "-b <bugid>". In this case asks for a bugtitle and a comment for the new bug.

I agree that the help message is not obvious.

We should avoid the wrong usage somehow. I think we shouldn't allow to use the bugurl in the ChangeLog and the -b "<bugid>" option at the same time. Or simply remove the "-b <bugid>" option from the upload command.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.