[Webkit-unassigned] [Bug 130898] [GTK] Geoclue2 providers won't work after reloading

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130898





--- Comment #3 from Mario Sanchez Prada <mario at webkit.org>  2014-03-28 07:46:49 PST ---
(In reply to comment #2)
> (From update of attachment 228049 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228049&action=review
> 
> > Source/WebCore/platform/geoclue/GeolocationProviderGeoclue2.cpp:76
> > -    startGeoclueClient();
> > +    geoclue_manager_call_get_client(m_managerProxy.get(), nullptr, reinterpret_cast<GAsyncReadyCallback>(getGeoclueClientCallback), this);
> 
> You don't mention in the changelog why you no longer call startGeoclueClient.

I no longer call him here because it will be called later on, once the client proxy is created, down in createGeoclueClientProxyCallback().

Not sure whether it's worth mentioning that in the ChangeLog?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.