[Webkit-unassigned] [Bug 129681] [GTK] Too many redirects visiting www.globalforestwatch.org

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129681





--- Comment #20 from Diego Pino <dpino at igalia.com>  2014-03-28 04:07:08 PST ---
(In reply to comment #18)
> (From update of attachment 226587 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=226587&action=review
> 
> Did you run unit tests. I think some of them check the expected user agent.
> 

Run master, Version/6.0 and Version/7.0. Here are the results:

Master:

* Tests that timed out (15): /WebKit2Gtk/TestWebKitWebView, /WebKit2Gtk/TestCookieManager, /WebKit2Gtk/TestWebExtensions, /WebKit2Gtk/TestWebKitWebViewGroup, /WebKit2Gtk/TestWebKitPolicyClient, /WebKit2Gtk/TestMultiprocess, /WebKit2Gtk/TestWebKitSettings, /WebKit2Gtk/TestWebKitAccessibility, /WebKit2Gtk/TestLoaderClient, /WebKit2Gtk/TestPrinting, /WebKit2Gtk/TestDOMNode, /WebKit2Gtk/TestFrame, /WebKit2Gtk/TestBackForwardList, /WebKit2Gtk/TestWebKitWebContext, /WebKitGtk/testwebinspector

* Tests skipped (23).

Version/6.0:

* Tests that timed out (13): /WebKit2Gtk/TestWebKitWebView, /WebKit2Gtk/TestCookieManager, /WebKit2Gtk/TestSSL, /WebKit2Gtk/TestWebExtensions, /WebKit2Gtk/TestWebKitWebViewGroup, /WebKit2Gtk/TestWebKitPolicyClient, /WebKit2Gtk/TestMultiprocess, /WebKit2Gtk/TestPrinting, /WebKit2Gtk/TestDOMNode, /WebKit2Gtk/TestFrame, /WebKit2Gtk/TestBackForwardList, /WebKit2Gtk/TestWebKitWebContext, /WebKitGtk/testwebinspector

* Tests skipped (23).

Version/7.0:

* Tests that timed out (16): /WebKit2Gtk/TestWebKitWebView, /WebKit2Gtk/TestCookieManager, /WebKit2Gtk/TestSSL, /WebKit2Gtk/TestWebExtensions, /WebKit2Gtk/TestWebKitWebViewGroup, /WebKit2Gtk/TestWebKitPolicyClient, /WebKit2Gtk/TestMultiprocess, /WebKit2Gtk/TestWebKitSettings, /WebKit2Gtk/TestWebKitAccessibility, /WebKit2Gtk/TestLoaderClient, /WebKit2Gtk/TestPrinting, /WebKit2Gtk/TestDOMNode, /WebKit2Gtk/TestFrame, /WebKit2Gtk/TestBackForwardList, /WebKit2Gtk/TestWebKitWebContext, /WebKitGtk/testwebinspector

* Tests skipped (23).

So, in the end I decided to set the version string to Version/6.0.

> > Source/cmake/OptionsGTK.cmake:149
> > +add_definitions(-DUSER_AGENT_SAFARI_MAJOR_VERSION=7)
> > +add_definitions(-DUSER_AGENT_SAFARI_MINOR_VERSION=0)
> 
> Not sure how I feel about adding more command-line arguments to the compiler.

OK, I appended Version/6.0 directly to the UserAgent string.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.