[Webkit-unassigned] [Bug 130391] [EFL] Page rendering is not proper when zooming and resizing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130391





--- Comment #8 from Ryuan Choi <ryuan.choi at samsung.com>  2014-03-27 17:43:00 PST ---
(From update of attachment 227949)
View in context: https://bugs.webkit.org/attachment.cgi?id=227949&action=review

> Source/WebKit2/ChangeLog:3
> +        [EFL] Page rendering is not proper when zooming and resizing.

I am still not sure whether this patch is to fix "Page rendering is not proper when zooming and resizing".

Let's change the bug title properly.
And [EFL][WK2] is correct prefix, IMO.

> Source/WebKit2/ChangeLog:13
> +        (ewk_view_page_zoom_factor_set):
> +        (ewk_view_page_zoom_factor_get):

Sorry, after discussed with jinwoo.
We'd better to use ewk_view_page_zoom_set/get.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:576
> + * Sets zoom of the current page.

s/zoom/zoom factor/

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:583
> +EAPI Eina_Bool ewk_view_page_zoom_factor_set(Evas_Object *o, double zoomFactor);

s/zoomFactor/zoom_factor/

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:586
> + * Queries the current zom factor of the page.

s/zom/zoom/

> Tools/ChangeLog:9
> +        Fixing an improper zooming in EFL WK2 by using WKPageSetPageZoomFactor via ewk_view_page_zoom_factor_set
> +        instead WKPageSetScaleFactor via ewk_view_scale_set.

This is not fixing improper zooming in EFL WK2.
It's replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set (maybe: because it looks more desired behaviour of zoom_level_set).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.