[Webkit-unassigned] [Bug 130577] [EFL][WK2]Implement ewk web local storage APIs which has delete function of the local storage entries

Thu Mar 27 17:16:13 PDT 2014

https://bugs.webkit.org/show_bug.cgi?id=130577

--- Comment #23 from Ryuan Choi <ryuan.choi at samsung.com>  2014-03-27 17:16:26 PST ---
(From update of attachment 227936)
View in context: https://bugs.webkit.org/attachment.cgi?id=227936&action=review

> Source/WebKit2/ChangeLog:14
> +        adding API unittest

I think that you need more description.

you not only added test case for ewk_storage_manager_entries_clear/ewk_storage_manager_entries_for_origin_del and also fixed leak of legacy test case.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:69
> +            ewk_object_unref((Ewk_Object*)originItem);

can we use static_cast<Ewk_Object*>(originItem) ?

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:135
> +        ewk_object_unref((Ewk_Object*)originItem);

can we use static_cast<Ewk_Object*>(originItem) ?

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:147
> +    const char* storageHTML =
> +        "<html><head><title>original title</title></head>"
> +        "<body>"
> +        "<script type='text/javascript'>"
> +        " localStorage.setItem('item', 'storage');"
> +        "</script>"
> +        "</body></html>";

It's duplicated in ewk_storage_manager_origins_async_get/ewk_storage_manager_entries_for_origin_delete.
How about moving it out of source code?
static char storageHTML[] = "...";

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:171
> +    ewk_storage_manager_entries_for_origin_del(originData.manager, static_cast<Ewk_Security_Origin*>(eina_list_nth(originData.originList, 0)));

Just question,
Can we guarantee first item is for www.storagetest1.com ?

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:175
> +        ewk_object_unref((Ewk_Object*)originItem);

can we use static_cast<Ewk_Object*>(originItem) ?

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:189
> +        ewk_object_unref((Ewk_Object*)originItem);

can we use static_cast<Ewk_Object*>(originItem) ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.