[Webkit-unassigned] [Bug 130848] Filter: pass by ref const on applyScale methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130848


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #227960|review?                     |review-
               Flag|                            |




--- Comment #2 from Dirk Schulze <krit at webkit.org>  2014-03-27 11:51:32 PST ---
(From update of attachment 227960)
View in context: https://bugs.webkit.org/attachment.cgi?id=227960&action=review

Not sure why you are doing that. passing a reference to a float is not more or less expecive than passing the value itself. All the float references should be turned back to normal float arguments.

> Source/WebCore/platform/graphics/filters/Filter.h:50
> +    virtual float applyHorizontalScale(const float& value) const { return value * m_filterResolution.width(); }
> +    virtual float applyVerticalScale(const float& value) const { return value * m_filterResolution.height(); }

there is no need to make the float a reference, it doesn't save anything.

> Source/WebCore/svg/graphics/filters/SVGFilter.cpp:39
> +float SVGFilter::applyHorizontalScale(const float& value) const

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.