[Webkit-unassigned] [Bug 130577] [EFL][WK2]Implement ewk web local storage APIs which has delete function of the local storage entries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130577





--- Comment #20 from Ryuan Choi <ryuan.choi at samsung.com>  2014-03-27 00:16:42 PST ---
(From update of attachment 227928)
View in context: https://bugs.webkit.org/attachment.cgi?id=227928&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:55
> +        void* originItem;
> +        EINA_LIST_FREE(originData->originList, originItem)
> +            ewk_object_unref((Ewk_Object*)originItem);

IMO, it's not wrong but it's not good.

These cleanup are for previous logic. so it's not proper to put these in `getStorageOriginsCallback`

Why don't you just release the list after used.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:169
> +    EXPECT_EQ(3, eina_list_count(originData.originList));
> +

here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.