[Webkit-unassigned] [Bug 130577] [EFL][WK2]Implement ewk web local storage APIs which has delete function of the local storage entries

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 26 22:59:34 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=130577





--- Comment #18 from Jinwoo Song <jinwoo7.song at samsung.com>  2014-03-26 22:59:52 PST ---
(From update of attachment 227924)
View in context: https://bugs.webkit.org/attachment.cgi?id=227924&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:128
> +        ecore_timer_del(storage_timer);

You should not free storage_timer again because timer is already fired in the callback. 
Instead you should initialize the timer variable as null.

storage_timer = nullptr;

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:165
>          ecore_timer_del(storage_timer);

Please fix here, too.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:180
> +        ecore_timer_del(storage_timer);

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list