[Webkit-unassigned] [Bug 130779] FEGaussianBlur: unify and const-ify calculateKernelSize

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130779


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #227864|review?                     |review-
               Flag|                            |




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com>  2014-03-26 10:59:39 PST ---
(From update of attachment 227864)
View in context: https://bugs.webkit.org/attachment.cgi?id=227864&action=review

> Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp:410
> +    FloatPoint stdFilterScaled(filter->applyHorizontalScale(stdDeviation.x()), filter->applyVerticalScale(stdDeviation.y()));

Since you dereference filter without a null check, you should make it a const Filter&

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.