[Webkit-unassigned] [Bug 130577] [EFL][WK2]Implement ewk web local storage APIs which has delete function of the local storage entries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130577





--- Comment #9 from Ryuan Choi <ryuan.choi at samsung.com>  2014-03-26 06:36:48 PST ---
(From update of attachment 227846)
View in context: https://bugs.webkit.org/attachment.cgi?id=227846&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.h:91
> +EAPI Eina_Bool ewk_storage_manager_all_entries_delete(Ewk_Storage_Manager *manager);

How about ewk_storage_manager_delete_all ?

> Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.h:101
> +EAPI Eina_Bool ewk_storage_manager_entries_for_origin_delete(Ewk_Storage_Manager *manager, Ewk_Security_Origin *origin);

How about just ewk_storage_manager_delete ?

> Source/WebKit2/UIProcess/API/efl/ewk_storage_manager_private.h:45
> +    inline WKRetainPtr<WKKeyValueStorageManagerRef> getStorageManager()
> +    {
> +        return m_storageManager;
> +    }

sing line looks better.
inline is unnecessary.

And wkStorageManager looks better, IMO.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:53
> +        originData->originList = 0;

originData->originList = nullptr;

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:61
> +            fprintf(stderr, "%s\n", ewk_security_origin_host_get(origin));

maybe, mistake?

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:133
> +TEST_F(EWK2StorageManagerTest, ewk_storage_manager_all_entries_delete)

Instead of adding this, we can test them using current test because you called it in _origins_async_get.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.