[Webkit-unassigned] [Bug 129740] [EFL][WK2] Add ewk APIs to control TLS error policy on WebContext.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129740





--- Comment #31 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2014-03-25 23:03:28 PST ---
(From update of attachment 227754)
View in context: https://bugs.webkit.org/attachment.cgi?id=227754&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:380
> +{

Don't we need to set true or false if result of TLSErrorPolicy == EWK_TLS_ERROR_POLICY_IGNORE was already set ?

How about adding below logic ?

    bool isNewPolicy = TLSErrorPolicy == EWK_TLS_ERROR_POLICY_IGNORE;
    if (toImpl(m_context.get())->ignoreTLSErrors() == isNewPolicy)
        return;

    toImpl(m_context.get())->setIgnoreTLSErrors(isNewPolicy);

> Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:490
> +void ewk_context_tls_error_policy_set(const Ewk_Context *context, Ewk_TLS_Error_Policy tls_error_policy)

Wrong * place. Ewk_Context* context

We only follow EFL coding style in public header.

> Source/WebKit2/UIProcess/API/efl/ewk_context.h:381
> + * @param context context object to get TLS error policy for

What is *for* at the end of line ?

> Source/WebKit2/UIProcess/API/efl/ewk_context.h:390
> + * @param context context object to set TLS error policy for

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.