[Webkit-unassigned] [Bug 129740] [EFL][WK2] Add ewk APIs to control TLS error policy on WebContext.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129740





--- Comment #28 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2014-03-24 16:53:37 PST ---
(From update of attachment 227659)
View in context: https://bugs.webkit.org/attachment.cgi?id=227659&action=review

Patch looks getting better.

> Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.h:29
> +    EWK2UnitTestServer(GTlsCertificate* tlsCert = nullptr);

Missing *explicit* keyword ?

> Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.h:30
>      virtual ~EWK2UnitTestServer();

Unrelated to this patch though, why this dtor was declared as virtual :(

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:182
> +    waitUntilTrue(finishTest, testTimeoutSeconds);

Any reason we have to wait until testTimeoutSeconds ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.