[Webkit-unassigned] [Bug 130577] implement ewk web storage API in ewk_context for EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130577





--- Comment #6 from Ryuan Choi <ryuan.choi at samsung.com>  2014-03-24 01:20:43 PST ---
(From update of attachment 227627)
View in context: https://bugs.webkit.org/attachment.cgi?id=227627&action=review

> Source/WebKit2/ChangeLog:4
> +        Implement ewk web storage APIs which has delete entries functionality.
> +        https://bugs.webkit.org/show_bug.cgi?id=130577.

Bug title is wrong.
Please change title of bug.

And add test case.

> Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.cpp:57
> +void EwkStorageManager::deleteAllStorageEntries()
> +{
> +    WKKeyValueStorageManagerDeleteAllEntries(m_storageManager.get());
> +}
> +
> +void EwkStorageManager::deleteStorageEntriesForOrigin(WKSecurityOriginRef origin)
> +{
> +    WKKeyValueStorageManagerDeleteEntriesForOrigin(m_storageManager.get(), origin);
> +}

Should we add this? IMO, we'd better to avoid these dummy methods.

> Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.cpp:125
> +    WKRetainPtr<WKStringRef> hostRef(AdoptWK, WKStringCreateWithUTF8CString(ewk_security_origin_host_get(origin)));
> +    WKRetainPtr<WKStringRef> protocolRef(AdoptWK, WKStringCreateWithUTF8CString(ewk_security_origin_protocol_get(origin)));
> +    WKRetainPtr<WKSecurityOriginRef> securityOriginRef(AdoptWK, WKSecurityOriginCreate(protocolRef.get(), hostRef.get(), ewk_security_origin_port_get(origin)));

Use EwkSecurityOrigin::wkSecurityOrigin() to get WKSecurityOrigin.

> Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.h:87
> + * @param context context object

wrong.

> Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.h:94
> + * Deletes origin and DBs related with the origin that is stored in web storage db.

It looks wrong.

> Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.h:96
> + * @param context context object

wrong.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.