[Webkit-unassigned] [Bug 129814] Regression: AX: Don't expose role or notifications for invalid menus

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129814


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-unassigned at lists.web |cfleizach at apple.com
                   |kit.org                     |
 Attachment #227154|                            |review?
               Flag|                            |

WebKit Commit Bot <commit-queue at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aboxhall at chromium.org,
                   |                            |apinheiro at igalia.com,
                   |                            |cfleizach at apple.com,
                   |                            |commit-queue at webkit.org,
                   |                            |dmazzoni at google.com,
                   |                            |jdiggs at igalia.com,
                   |                            |mario at webkit.org,
                   |                            |samuel_white at apple.com

Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #227154|review?                     |review+
               Flag|                            |




--- Comment #3 from chris fleizach <cfleizach at apple.com>  2014-03-18 20:58:38 PST ---
Created an attachment (id=227154)
 --> (https://bugs.webkit.org/attachment.cgi?id=227154&action=review)
patch

--- Comment #4 from Mario Sanchez Prada <mario at webkit.org>  2014-03-21 11:31:28 PST ---
(From update of attachment 227154)
View in context: https://bugs.webkit.org/attachment.cgi?id=227154&action=review

Lgtm. Please consider those suggestions below before landing

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:121
> +    m_object->updateChildrenIfNecessary();

For your consideration before landing: I wonder if you could fold this into updateBackingStore(), so you don't need to call it explicitly here, and other platforms get benefit from that too

> LayoutTests/ChangeLog:13
> +        * platform/mac/accessibility/table-with-aria-role-expected.txt:

You can move this test expectation now to LayoutTests/accessibility, as there should produce the same (platform independent) output now for all the platforms

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.