[Webkit-unassigned] [Bug 130576] Constants folded by DFG::ByteCodeParser should not be dead.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130576





--- Comment #5 from Filip Pizlo <fpizlo at apple.com>  2014-03-21 09:31:14 PST ---
Thought about it more. I think that your approach can work, but:

- we already have a ton of complexity in the byte code parser's folder and we have bugs because of it. Your patch adds complexity. 

- it's not at all clear that this folder is buying us any performance. Hence it may just be a complex piece of code that is only getting more complex that literally buys nothing but pain. 

- your test is incomplete. It doesn't cover all of the cases where you added phantoms. At a minimum you should give this 100% test coverage. That's a hard prerequisite for landing this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.