[Webkit-unassigned] [Bug 129740] [EFL] Add WK2 API to control TLS error policy on WebContext.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129740





--- Comment #20 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2014-03-20 18:45:16 PST ---
(From update of attachment 227203)
View in context: https://bugs.webkit.org/attachment.cgi?id=227203&action=review

Looks fine except for EFL coding style.

> Source/WebKit2/UIProcess/API/efl/ewk_context.h:383
> + * @param context context object to get TLS error policy for.

For @param, @return statements, we haven't used . at the end of line.

> Source/WebKit2/UIProcess/API/efl/ewk_context.h:385
> + * @return The TLS errors policy for the context.

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_context.h:387
> +Ewk_TLS_Error_Policy ewk_context_tls_error_policy_get(const Ewk_Context *ewkContext);

Please use context instead of ewkContext to be compliant with existing APIs.

> Source/WebKit2/UIProcess/API/efl/ewk_context.h:392
> + * @param context context object to set TLS error policy for.

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_context.h:393
> + * @param ignore_tls_errors a #Ewk_TLS_Error_Policy.

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_context.h:395
> +EAPI void ewk_context_tls_error_policy_set(const Ewk_Context *ewkContext, Ewk_TLS_Error_Policy tls_error_policy);

ditto.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:100
> +        // The test fails if an SSL error occurs.

Wrong indentation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.