[Webkit-unassigned] [Bug 130473] Implement isPointInPath and isPointInStroke with Path2D argument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130473


Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #227215|review?                     |review+
               Flag|                            |




--- Comment #2 from Dean Jackson <dino at apple.com>  2014-03-19 14:35:04 PST ---
(From update of attachment 227215)
View in context: https://bugs.webkit.org/attachment.cgi?id=227215&action=review

> LayoutTests/fast/canvas/canvas-path-isPointInPath-expected.txt:12
> +PASS ctx.isPointInPath(null, 50, 50) threw exception TypeError: Argument 3 ('winding') to CanvasRenderingContext2D.isPointInPath must be one of: "nonzero", "evenodd".

Discussion on irc suggests this error message is wrong.

> LayoutTests/fast/canvas/script-tests/canvas-path-isPointInPath.js:34
> +shouldThrow("ctx.isPointInPath({}, 50, 50, 'nonzero')");
> +shouldThrow("ctx.isPointInPath({}, 50, 50, 'evenodd')");

I would like to see some tests where you are passing in some extremely unexpected data, such as Number.MAX_VALUE or strings, etc.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.