[Webkit-unassigned] [Bug 130438] Small cleanup of empty string

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130438


Gavin Barraclough <barraclough at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #227144|                            |review?
               Flag|                            |
         AssignedTo|webkit-unassigned at lists.web |barraclough at apple.com
                   |kit.org                     |

WebKit Commit Bot <commit-queue at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin at webkit.org,
                   |                            |cmarcelo at webkit.org,
                   |                            |commit-queue at webkit.org

Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |akling at apple.com

Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #227144|review?                     |review+
               Flag|                            |

Gavin Barraclough <barraclough at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #227144|0                           |1
        is obsolete|                            |
         Resolution|                            |FIXED
             Status|NEW                         |RESOLVED




--- Comment #1 from Gavin Barraclough <barraclough at apple.com>  2014-03-18 19:05:32 PST ---
Created an attachment (id=227144)
 --> (https://bugs.webkit.org/attachment.cgi?id=227144&action=review)
Fix

--- Comment #2 from Andreas Kling <akling at apple.com>  2014-03-18 19:08:22 PST ---
The PCRE workaround removal has been attempted before, see bug 123265.

--- Comment #3 from Gavin Barraclough <barraclough at apple.com>  2014-03-18 19:21:15 PST ---
(In reply to comment #2)
> The PCRE workaround removal has been attempted before, see bug 123265.

Hmmm, interesting. :-(

The tests mentioned in the bug pass for me, maybe I should try again. :-/

--- Comment #4 from Anders Carlsson <andersca at apple.com>  2014-03-18 19:22:15 PST ---
(From update of attachment 227144)
View in context: https://bugs.webkit.org/attachment.cgi?id=227144&action=review

> Source/WTF/wtf/text/StringImpl.h:164
> +        , m_data8(reinterpret_cast<LChar*>(1))

Even though this is what the comment said, I think it's awkward. I think you should do what we do for the StringImpl(CreateEmptyUniqueTag) constructor instead:

// We expect m_length to be initialized to 0 as we use it
// to represent a null terminated buffer.
, m_data8(reinterpret_cast<const LChar*>(&m_length))

> Source/WTF/wtf/text/StringStatics.cpp:46
> +    DEPRECATED_DEFINE_STATIC_LOCAL(StringImpl, emptyString, (ConstructEmptyString));

Please change this to

static NeverDestroyed<StringImpl> emptyString(ConstructEmptyString);

instead.

--- Comment #5 from Gavin Barraclough <barraclough at apple.com>  2014-03-18 19:41:44 PST ---
Created an attachment (id=227148)
 --> (https://bugs.webkit.org/attachment.cgi?id=227148&action=review)
Patch with review comments for EWS

--- Comment #6 from Gavin Barraclough <barraclough at apple.com>  2014-03-19 12:02:56 PST ---
Fixed in r165906

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.