[Webkit-unassigned] [Bug 130360] [iOS] WebKit2 Quicklook.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130360


Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #227165|review?                     |review+
               Flag|                            |




--- Comment #11 from Tim Horton <thorton at apple.com>  2014-03-19 11:03:24 PST ---
(From update of attachment 227165)
View in context: https://bugs.webkit.org/attachment.cgi?id=227165&action=review

Sam gives his blessing as well, but bugzilla is not cooperating for him.

> Source/WebCore/platform/network/ios/QuickLook.mm:399
> +        return adoptPtr(new QuickLookHandle(NULL, nil, response, delegate));

nullptr for the first arg, which is a C++ type?

> Source/WebKit2/WebProcess/ios/WebResourceLoaderIOS.mm:45
> +- (id)initWithWebResourceLoader:(PassRefPtr<WebKit::WebResourceLoader>)loader

instancetype for the return value?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.