[Webkit-unassigned] [Bug 130455] Update some references for MathML pixels tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 19 10:38:40 PDT 2014


--- Comment #2 from Frédéric Wang <fred.wang at free.fr>  2014-03-19 08:50:38 PST ---
Created an attachment (id=227187)
 --> (https://bugs.webkit.org/attachment.cgi?id=227187&action=review)
Patch V1

Here are the failing tests whose ref must be updated.

--- Comment #3 from Frédéric Wang <fred.wang at free.fr>  2014-03-19 10:20:41 PST ---
So I just tried on GTK+:


- I'm not sure what is tested by the "x+1" but we have other tests for token elements.
- The test used green <div> inside <mtext> which is invalid (see bug 124128). They should be replaced with <mspace> or inline-block span. 
- The stretchy operators are already tested in mo-stretch and they are many other reftests for operator stretching.

=> So actually I think we can remove the whole test?


- only some small spacing changes
- I already rewrote the last "don't wrap" test as a reftest LayoutTests/mathml/presentation/bug95015.html so it can be removed.


- one test uses the invalid <div> in <mtext> (see above)
- it's not clear to me what the other tests verify, but I believe we already test mfrac/mo/mathsize elsewhere...

=> Should we remove that test?

For the other platforms, I believe it is safe to just update the references of mathml/presentation/mspace-children.html and mathml/presentation/mo-stretch.html.

--- Comment #4 from Frédéric Wang <fred.wang at free.fr>  2014-03-19 10:38:58 PST ---
Created an attachment (id=227194)
 --> (https://bugs.webkit.org/attachment.cgi?id=227194&action=review)

Here is an updated patch, that tries to fix some errors in the tests.

It seems that setting background color on <mo> (but not on other token elements) is broken so I'll open a separate bug for that and write a reftest.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list