[Webkit-unassigned] [Bug 130392] [CSSRegions] Compute region ranges for children of inline blocks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 19 05:42:42 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=130392


Andrei Bucur <abucur at adobe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #227044|review?                     |review+
               Flag|                            |

Mihnea Ovidenie <mihnea at adobe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #227044|                            |commit-queue+
               Flag|                            |

WebKit Commit Bot <commit-queue at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #227044|review+, commit-queue+      |
               Flag|                            |
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Mihnea Ovidenie <mihnea at adobe.com>  2014-03-19 01:18:56 PST ---
(From update of attachment 227044)
View in context: https://bugs.webkit.org/attachment.cgi?id=227044&action=review

>> Source/WebCore/rendering/RenderFlowThread.cpp:801
>> +            endRegion = startRegion;
> 
> An unsplittable box should always have startRegion == endRegion. Shouldn't this line be an assertion instead?

Yes, you are right :)

>> Source/WebCore/rendering/RenderObject.cpp:529
>> +    if (flowThread && (flowThreadState() == flowThread->flowThreadState()))
> 
> What's this change for?

Assume you have a region-based multicolumn flow thread inside a named flow and you have the multi-column flow thread set as the current flow thread. Now suppose you want to compute borderBoxRectInRegion for the multicolumnflowthread and the region being the rendermulticolumnset. When you ask for containingBlock renderBoxRegionInfo, you go out of rendermulticolumnthread boundary and for these boxes, flowThreadContainingBlock() will return the wrong result.

There are some possible solutions to this problem:
* the check above, which ensures that when you are in the middle of layout and you cross the flow thread boundary, you still get the right result
* add a check in RenderBox::renderBoxRegionInfo so that we return 0 if the flowThreadContainingBlock flowThreadState is different than the box flowThreadState

--- Comment #4 from Andrei Bucur <abucur at adobe.com>  2014-03-19 04:47:10 PST ---
(From update of attachment 227044)
r=me

--- Comment #5 from WebKit Commit Bot <commit-queue at webkit.org>  2014-03-19 05:39:19 PST ---
(From update of attachment 227044)
Clearing flags on attachment: 227044

Committed r165890: <http://trac.webkit.org/changeset/165890>

--- Comment #6 from WebKit Commit Bot <commit-queue at webkit.org>  2014-03-19 05:42:26 PST ---
All reviewed patches have been landed.  Closing bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list