[Webkit-unassigned] [Bug 130360] [iOS] WebKit2 Quicklook.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130360





--- Comment #4 from Tim Horton <thorton at apple.com>  2014-03-18 13:53:41 PST ---
(From update of attachment 226976)
View in context: https://bugs.webkit.org/attachment.cgi?id=226976&action=review

> Source/WebCore/WebCore.exp.in:2689
> +__ZN7WebCore15QuickLookHandleD1Ev

Did you run sort-export-file?

> Source/WebCore/loader/ResourceLoader.h:39
> +#include "QuickLook.h"

Perhaps we should put this guard around the header instead of around each include?

> Source/WebCore/loader/ResourceLoader.h:162
> +    QuickLookHandle *quickLookHandle() const { return m_quickLookHandle.get(); }

Star on the wrong side.

> Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:150
> +    m_webResourceLoaders.set(identifier, WebResourceLoaderIOS::create(resourceLoader));

maybe WebResourceLoader::create should make the right thing on each platform?

> Source/WebKit2/WebProcess/ios/WebResourceLoaderIOS.h:35
> +class WebResourceLoaderIOS : public WebResourceLoader {

this class can be 'final'

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.