[Webkit-unassigned] [Bug 130343] New: REGRESSION(r165704): [GTK] Inspector resources not correctly generated

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130343

           Summary: REGRESSION(r165704): [GTK] Inspector resources not
                    correctly generated
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: Gtk
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: cgarcia at igalia.com
                CC: gns at gnome.org, zandobersek at gmail.com,
                    mrobinson at webkit.org


Since r165704 there are two resources that are now generated. This revealed some problems in the way we generate the inspector resources:

 - The script generate-inspector-gresource-manifest.py doesn't receive the list of resources from the makefile, but it duplicates the expression in the makefile to generate the resources list again. This is very easy to end up out of sync, and people from other ports are not expected to know we have this duplication.

 - We are generating the resources xml file using paths relative to Source/WebInspectorUI, but the new files are in DerivedSources. We should use top source dir and use full paths Source/ buldir/DerivedSource, etc. To keep the same names for the gresources, we need to use alias, something like: <file alias="UserInterface/External/CodeMirror/css.js">Source/WebInspectorU/UserInterface/External/CodeMirror/css.js</file>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.