[Webkit-unassigned] [Bug 129802] [GTK] Don't busy loop when the socket is full

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129802


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #225992|review?                     |review-
               Flag|                            |




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-03-17 01:40:36 PST ---
(From update of attachment 225992)
View in context: https://bugs.webkit.org/attachment.cgi?id=225992&action=review

Thanks for the patch. This patch needs a ChangeLog, see http://www.webkit.org/coding/contributing.html.

> Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:37
> +#include <poll.h>

Is this available in all UNIX platforms?

> Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:535
> +            poll(&pollfd, 1, -1);
> +        }

Does this really work? Don't you need to continue the loop when poll returns?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.