[Webkit-unassigned] [Bug 114960] Wrong text position when you click backspace on the line below the image

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 14 17:49:59 PDT 2014


--- Comment #49 from Ryosuke Niwa <rniwa at webkit.org>  2014-03-14 17:50:18 PST ---
(From update of attachment 226672)
View in context: https://bugs.webkit.org/attachment.cgi?id=226672&action=review

> LayoutTests/editing/deleting/merge-image-and-text.html:6
> +<div><span><img src="some_img" style="color:#FF0000"></span></div>

Can't we use ../abe.png instead?  Why do we need to have style attribute?  Is that required?

> LayoutTests/editing/deleting/merge-image-and-text.html:7
> +<div><span id="textSpan" style="color:#FF0000">text</span></div>

Ditto about style attribute.

> LayoutTests/editing/deleting/merge-image-and-text.html:11
> +Markup.description('Wrong text position when you click backspace on the line below the image.');

This description isn't descriptive enough.  We should explain what kind of behavior this test is testing.

> LayoutTests/editing/deleting/merge-image-and-text.html:15
> +var selection = window.getSelection();

We don't need this local variable.

> LayoutTests/editing/deleting/merge-image-and-text.html:16
> +Markup.dump(editElement, 'Before Delete');

I don't see a value in dumping the content without selection since that's basically identical to the content with caret in it.

> LayoutTests/editing/deleting/merge-image-and-text.html:18
> +selection.collapse(text, text.childNodes.length -1);

Just call getSelecrtion() here.
Nit: text.childNodes.length - 1.

> LayoutTests/editing/deleting/merge-image-and-text.html:19
> +Markup.dump(text, 'Place the cursor at');

It's useless to dump the content of text because we don't know where "text" is located at in the original content.
We should dump the whole editElement here and label this one as 'Before deletion' instead.

> LayoutTests/editing/deleting/merge-image-and-text.html:22
> +Markup.dump(editElement, 'After Delete');

'After deletion'.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list