[Webkit-unassigned] [Bug 130123] Incorrect Date returned between March 1, 2034 and February 28, 2100.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130123


Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #226779|review?                     |review-
               Flag|                            |




--- Comment #13 from Mark Lam <mark.lam at apple.com>  2014-03-14 17:18:29 PST ---
(From update of attachment 226779)
View in context: https://bugs.webkit.org/attachment.cgi?id=226779&action=review

Almost there. =)  Please fix the remaining issues.  For your updated patch, mark it cq? if you need it to be committed via the commit-queue.

> LayoutTests/js/script-tests/date-constructor.js:81
> +        shouldBe(“new Date(“ + dateString + “).getFullYear()”, year);

Please use the ascii double quote character ‘“' instead of '‒.

> LayoutTests/js/script-tests/date-constructor.js:84
> +        shouldBe(“new Date(“ + dateString + “).getMonth()”, month);

Ditto.

> LayoutTests/js/script-tests/date-constructor.js:87
> +        shouldBe(“new Date(“ + dateString + “).getDate()”, date);

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.