[Webkit-unassigned] [Bug 130195] [CMake] Failure to link with older installations of WebP

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 14 03:09:29 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=130195


Csaba Osztrogonác <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ossy at webkit.org




--- Comment #9 from Csaba Osztrogonác <ossy at webkit.org>  2014-03-14 03:09:48 PST ---
I ran into the same bug and I can confirm that the committed fix is the
proper fix.

The root of the problem is the implementation of check_include_files

MACRO(CHECK_INCLUDE_FILES INCLUDE VARIABLE)
  IF("${VARIABLE}" MATCHES "^${VARIABLE}$") -----------> BANG !!!!!!!
....
  ENDIF("${VARIABLE}" MATCHES "^${VARIABLE}$")
ENDMACRO(CHECK_INCLUDE_FILES)


It is true if and only if the actual VARIABLE argument is undefined,
but "pkg_check_modules(WEBP libwebp)" in Source/cmake/FindWebP.cmake
set WEBP_FOUND to empty string. I confirmed it on a small example.
(But this kind of check only works inside macros. Otherwise it is always
true for undefined variable, empty string, non-empty string too.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list