[Webkit-unassigned] [Bug 130059] Refactor Vibration algorithm to use only one timer.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130059





--- Comment #11 from Jinwoo Jeong <jw00.jeong at samsung.com>  2014-03-13 18:37:52 PST ---
(In reply to comment #8)
> (From update of attachment 226477 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=226477&action=review
> 
> > Source/WebCore/Modules/vibration/Vibration.cpp:72
> > +    // Pre-exsiting instance need to be canceled when vibrate() is called.
> 
> Typo: "exsiting".
> 
> > Source/WebCore/Modules/vibration/Vibration.h:43
> > +    // FIXME : When visibilitychange event is dispatched, if a vibration is working, it should be canceled.
> 
> No space before the ":" in "FIXME:".
> 
> I don’t understand the meaning of the phrase “a vibration is working”.
> 
> > Source/WebCore/Modules/vibration/Vibration.h:58
> > +    enum class State {
> > +        Idle,
> > +        Vibrating,
> > +        Waiting
> > +    };
> 
> I’d suggest putting this on a single line instead of 5 lines.


Applied Darin's comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.