[Webkit-unassigned] [Bug 114960] Wrong text position when you click backspace on the line below the image

Thu Mar 13 10:59:58 PDT 2014

https://bugs.webkit.org/show_bug.cgi?id=114960

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #226484|review?                     |review-
               Flag|                            |

--- Comment #35 from Darin Adler <darin at apple.com>  2014-03-13 11:00:18 PST ---
(From update of attachment 226484)
View in context: https://bugs.webkit.org/attachment.cgi?id=226484&action=review

This patch is OK, but I’d like to see a better test. We shouldn’t land with a test that we know will fail on some platforms.

> LayoutTests/editing/deleting/merge-image-and-text-expected.txt:11
> +            RenderText {#text} at (4,0) size 31x17

This is non-portable, so this test is going to fail on some platforms. The text might not be 31 pixels wide on every platform due to font differences.

> LayoutTests/editing/deleting/merge-image-and-text.html:1
> +<!DOCTYPE html>

It’s much better for editing tests to dump markup rather than a render tree. Look at a recently added editing tests such as editing/execCommand/indent-img-twice.html to see how to do this. It makes a much useful test for the WebKit project. And deals with the portability issue I mentioned above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.