[Webkit-unassigned] [Bug 130059] Refactor Vibration algorithm to use only one timer.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130059


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #226477|review?                     |review+
               Flag|                            |




--- Comment #8 from Darin Adler <darin at apple.com>  2014-03-13 10:56:27 PST ---
(From update of attachment 226477)
View in context: https://bugs.webkit.org/attachment.cgi?id=226477&action=review

> Source/WebCore/Modules/vibration/Vibration.cpp:72
> +    // Pre-exsiting instance need to be canceled when vibrate() is called.

Typo: "exsiting".

> Source/WebCore/Modules/vibration/Vibration.h:43
> +    // FIXME : When visibilitychange event is dispatched, if a vibration is working, it should be canceled.

No space before the ":" in "FIXME:".

I don’t understand the meaning of the phrase “a vibration is working”.

> Source/WebCore/Modules/vibration/Vibration.h:58
> +    enum class State {
> +        Idle,
> +        Vibrating,
> +        Waiting
> +    };

I’d suggest putting this on a single line instead of 5 lines.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.