[Webkit-unassigned] [Bug 130101] Ensure that layout milestones complete in all cases

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130101





--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com>  2014-03-13 09:03:49 PST ---
(From update of attachment 226451)
View in context: https://bugs.webkit.org/attachment.cgi?id=226451&action=review

Should we make a way to layout-test milestones?

> Source/WebCore/page/FrameView.cpp:2669
> +    if (auto* page = frame().page()) {
> +        if (auto* scrollingCoordinator = page->scrollingCoordinator())

Why auto here...

>> Source/WebCore/page/FrameView.cpp:4129
>> +    Page* page = frame().page();
>> +    if (page)
> 
> I’d put the variable inside the if statement.

but no auto here? I'd prefer less auto, not more.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.