[Webkit-unassigned] [Bug 130101] Ensure that layout milestones complete in all cases

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130101





--- Comment #5 from Antti Koivisto <koivisto at iki.fi>  2014-03-13 08:45:47 PST ---
> It’s hard to understand the relationships here. I think that future me would understand this better if the function the document called on FrameView was named something more like “document emptiness status may have changed”, and that function would then turn around and do this:
> 
>     if (!needsLayout) fireLayoutRelatedMilestonesIfNeeded
> 
> within the FrameView class.

Didn't do this. That would essentially be another finishedParsing function which we already have in multiple places. Some sort of bigger cleanup is needed.

> I’d put the variable inside the if statement.

It is used below too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.