[Webkit-unassigned] [Bug 130156] Allocate the data section on the heap again for FTL on ARM64

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130156


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #226549|review?                     |review+, commit-queue+
               Flag|                            |




--- Comment #2 from Geoffrey Garen <ggaren at apple.com>  2014-03-12 23:42:26 PST ---
(From update of attachment 226549)
View in context: https://bugs.webkit.org/attachment.cgi?id=226549&action=review

r=me

> Source/JavaScriptCore/ftl/FTLCompile.cpp:84
> +    // Allocate the GOT in the code section to make it reachable for all code.
> +    if (!strcmp(sectionName, "__got"))
> +        return mmAllocateCodeSection(opaqueState, size, alignment, sectionID, sectionName);

As a follow-up, we'll need to allocate the GOT outside executable memory -- otherwise we're still subject to "JIT spray" attacks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.