[Webkit-unassigned] [Bug 130132] [EFL][WK2] Fix compilation warning in Minibrowser

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 12 18:21:43 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=130132





--- Comment #5 from Sanghyup Lee <sh53.lee at samsung.com>  2014-03-12 18:22:05 PST ---
(In reply to comment #2)
> (From update of attachment 226511 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=226511&action=review
> 
> > Tools/ChangeLog:8
> > +        Replace mktemp() with mkdtemp() to fix compilation warning in MiniBrowser.
> 
> typo: you meant mkstemp instead of mkdtemp
> 
> > Tools/MiniBrowser/efl/main.c:606
> > -        eina_strbuf_append(destination_path, mktemp(unique_path));
> > +        mkstemp(unique_path);
> > +        eina_strbuf_append(destination_path, unique_path);
> 
> Shouldn't we check if the return value is -1 ?

Thanks for review. I fixed it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list