[Webkit-unassigned] [Bug 130161] New: Web Inspector: Classname stuff in WebInspector.displayNameForNode should join DOMTokenList classList instead of using string parsing and concatenation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 12 15:38:22 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=130161

           Summary: Web Inspector: Classname stuff in
                    WebInspector.displayNameForNode should join
                    DOMTokenList classList instead of using string parsing
                    and concatenation
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jcraig at apple.com
                CC: timothy at apple.com, joepeck at webkit.org,
                    webkit-bug-importer at group.apple.com,
                    graouts at webkit.org


Web Inspector: Classname stuff in WebInspector.displayNameForNode should join DOMTokenList classList instead of using string parsing and concatenation. Unless I'm missing something, I expect this was just written before DOMTokenList classList was available.

    var classAttribute = node.getAttribute("class");
    if (classAttribute) {
        var classes = classAttribute.trim().split(/\s+/);
        var foundClasses = {};

        for (var i = 0; i < classes.length; ++i) {
            var className = classes[i];
            if (className && !(className in foundClasses)) {
                title += "." + className;
                foundClasses[className] = true;
            }
        }
    }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list