[Webkit-unassigned] [Bug 130032] Web Inspector: Hang in Remote Inspection triggering breakpoint from console

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130032


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #226328|review?                     |review+
               Flag|                            |




--- Comment #2 from Timothy Hatcher <timothy at apple.com>  2014-03-12 11:43:20 PST ---
(From update of attachment 226328)
View in context: https://bugs.webkit.org/attachment.cgi?id=226328&action=review

> Source/JavaScriptCore/inspector/EventLoop.cpp:43
> +CFStringRef EventLoop::remoteInspectorRunLoopMode()
> +{
> +    return CFSTR("com.apple.JavaScriptCore.remote-inspector-runloop-mode");
> +}

This makes EventLoop more about Inspector than before. But it is in the inspector directory, so I guess it is fine.

> Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.mm:123
> +        CFRunLoopAddSource(CFRunLoopGetMain(), rwiRunLoopSource, kCFRunLoopDefaultMode);
> +        CFRunLoopAddSource(CFRunLoopGetMain(), rwiRunLoopSource, EventLoop::remoteInspectorRunLoopMode());

Needs added to both so paused and non-paused works? Maybe add a comment?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.