[Webkit-unassigned] [Bug 129857] Web Inspector: JSContext inspection - TypeError: null is not an object (evaluating 'contentView.showSourceCode')

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129857


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #226074|review?                     |review+
               Flag|                            |




--- Comment #3 from Timothy Hatcher <timothy at apple.com>  2014-03-12 11:23:13 PST ---
(From update of attachment 226074)
View in context: https://bugs.webkit.org/attachment.cgi?id=226074&action=review

I think this is fine. Only concern I have is the use of this.parentSidebar.selectedSidebarPanel.show().

> Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js:112
> +            this.parentSidebar.selectedSidebarPanel.show();

I am not sure this is right. Why do we need to force the sidebar to show? A comment would be good about why it is forced to show and why this uses this.parentSidebar.selectedSidebarPanel.

> Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js:117
> +        this.parentSidebar.selectedSidebarPanel.show();

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.