[Webkit-unassigned] [Bug 130014] [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 12 10:04:53 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=130014





--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-03-12 10:05:10 PST ---
(In reply to comment #7)
> (From update of attachment 226518 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=226518&action=review
> 
> > Source/cmakeconfig.h.cmake:130
> > +#ifndef GTK_API_VERSION_2
> 
> We should probably use #if defined(BUILDING_GTK__) && !defined(GTK_API_VERSION_2) so that this doesn't leak into other ports.

Ah, didn't know this was shared file. Another problem of this patch is that it doesn't work for MiniBrowser, I guess it's because it doesn't include this config file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list