[Webkit-unassigned] [Bug 130014] [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130014


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrobinson at webkit.org




--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2014-03-12 08:48:56 PST ---
(In reply to comment #3)
> Created an attachment (id=226504)
 --> (https://bugs.webkit.org/attachment.cgi?id=226504&action=review) [details]
> Patch
> 
> This one seems to work

I was testing something like this last night:

diff --git a/Source/cmake/OptionsGTK.cmake b/Source/cmake/OptionsGTK.cmake
index a6974e1..caa57bf 100644
--- a/Source/cmake/OptionsGTK.cmake
+++ b/Source/cmake/OptionsGTK.cmake
@@ -108,6 +108,7 @@ if (NOT USE_GTK2)
     set(GTK_API_VERSION 3.0)
     set(ENABLE_PLUGIN_PROCESS ON)
     set(ENABLE_WEBKIT2 ON)
+    set(GDK_VERSION_MIN_REQUIRED "GDK_VERSION_3_6")
 else ()
     set(WEBKITGTK_API_VERSION 2.0)
     set(GTK_API_VERSION 2.0)
diff --git a/Source/cmakeconfig.h.cmake b/Source/cmakeconfig.h.cmake
index c9c2f3b..de643b5 100644
--- a/Source/cmakeconfig.h.cmake
+++ b/Source/cmakeconfig.h.cmake
@@ -127,4 +127,6 @@
 #cmakedefine01 WTF_USE_TILED_BACKING_STORE
 #cmakedefine01 HAVE_LLVM

+#define GDK_VERSION_MIN_REQUIRED @GDK_VERSION_MIN_REQUIRED@
+
 #endif /* CMAKECONFIG_H */


I'd prefer it, if it works, since it avoid adding another command-line compiler argument.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.