[Webkit-unassigned] [Bug 130111] New: Web Inspector: generated backend commands should reflect build system ENABLE settings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130111

           Summary: Web Inspector: generated backend commands should
                    reflect build system ENABLE settings
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: bburg at apple.com
                CC: timothy at apple.com, joepeck at webkit.org,
                    webkit-bug-importer at group.apple.com,
                    graouts at webkit.org


Currently the commands that we generate (InspectorFooBackendCommands.js) include all domains, without checking whether their feature flags are actually enabled in the build system. This is fine for C++ code where we can just wrap the relevant agents and type builders in ENABLE(FOO_FEATURE).

This blocks frontend feature detection for ENABLE(WEB_REPLAY), which is not enabled by default. We want to support it being either on or off, but right now the frontend will always think it's available, whether or not the ReplayAgent backend has been compiled or not.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.