[Webkit-unassigned] [Bug 129478] [CSSRegions] Children of inline-block content-node are not displayed in regions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129478





--- Comment #4 from Andrei Bucur <abucur at adobe.com>  2014-03-11 09:08:56 PST ---
(From update of attachment 226427)
View in context: https://bugs.webkit.org/attachment.cgi?id=226427&action=review

> Source/WebCore/rendering/RenderBoxModelObject.h:-183
> -    bool canHaveBoxInfoInRegion() const { return !isFloating() && !isReplaced() && !isInline() && !hasColumns() && !isTableCell() && isRenderBlock() && !isRenderSVGBlock(); }

I don't think we want to remove the isInline check. We just want to allow inline blocks. Maybe isInlineBlockOrInlineTable is good enough?

> Source/WebCore/rendering/RenderFlowThread.cpp:594
> +    for (auto& region : m_regionList)

Why have you changed this code? There shouldn't be any region box info outside the range. If there is, we can catch it with the assert later on.

> Source/WebCore/rendering/RenderFlowThread.cpp:790
> +    } while (!cb->isRenderFlowThread());

This is correct but I think we can stop earlier, at the first line with a containing region. However, I like this more for the sake of simplicity.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.