[Webkit-unassigned] [Bug 34189] check-webkit-style failed to complain about missing braces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34189


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #225982|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org>  2014-03-11 00:42:55 PST ---
(From update of attachment 225982)
View in context: https://bugs.webkit.org/attachment.cgi?id=225982&action=review

rs=me.

> Tools/Scripts/webkitpy/style/checkers/cpp.py:2407
> +    if (match(r'^\s*\b(if|for|foreach|while|else)\b\s', line)

We don't want foreach here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.