[Webkit-unassigned] [Bug 130047] Expose runJavascript API to WKWebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130047


mitz at webkit.org <mitz at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #226347|review?                     |review+
               Flag|                            |




--- Comment #2 from mitz at webkit.org <mitz at webkit.org>  2014-03-10 16:20:55 PST ---
(From update of attachment 226347)
View in context: https://bugs.webkit.org/attachment.cgi?id=226347&action=review

> Source/WebKit2/ChangeLog:3
> +        Add SPI to run javascript in main frame on WKWebView.

No need for this. The bug title and URL below suffice. Although this makes for a better title than the bug’s current title.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:856
> +    _page->runJavaScriptInMainFrame(scriptString, WebKit::ScriptValueCallback::create([](bool b, WebKit::WebSerializedScriptValue* sv){}));

We typically don’t name unused parameters.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.