[Webkit-unassigned] [Bug 130027] [GLIB] Add GMainLoopSource class to wrap idle and timeout source

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130027





--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-03-10 12:11:54 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > (From update of attachment 226318 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=226318&action=review
> > 
> > >>> Source/WebKit/gtk/webkit/webkitwebview.cpp:5338
> > >>> +    }
> > >> 
> > >> Aren't we leaking subResources now since the original list is not freed?
> > > 
> > > The function doesn't have documentation, I assumed the return value is transfer container, so the user frees the returned list. This is doing the same than the current code, it copies the list (the container) and frees everything in an idle.
> > 
> > Well in the old code g_list_free is called on the subResources returned. In this version, the contents of the original list are freed, but not the actual list itself.
> 
> Where does that happen?

If you mean the g_list_free(subResources); in line 5324, that's not the returned list, but the copied list passed to the callback. This patch does the same but using g_list_free_full instead of g_list_foreach + g_list_free

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.