[Webkit-unassigned] [Bug 129919] Set background color of WK2's UIScrollView to the pageExtendedBackgroundColor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129919





--- Comment #5 from Beth Dakin <bdakin at apple.com>  2014-03-10 11:58:34 PST ---
(In reply to comment #4)
> (From update of attachment 226181 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=226181&action=review
> 
> > Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h:207
> > +    WebCore::Color m_pageExtendedBackgroundColor;
> 
> Let's move this above with content size.
> 

Okay!

> > Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:426
> > +    encoder << m_pageExtendedBackgroundColor;
> 
> And update this accordingly.
> 

Done.

> > Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:492
> > +    if (!decoder.decode(result.m_pageExtendedBackgroundColor))
> > +        return false;
> > +
> 
> And this.
> 

Done.

> > Source/WebKit2/UIProcess/WebPageProxy.h:432
> > +    void setPageExtendedBackgroundColor(const WebCore::Color& color) { m_pageExtendedBackgroundColor = color; }
> 
> You should not need this.
> 

Removed.

> > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:340
> > +    _page->setPageExtendedBackgroundColor(layerTreeTransaction.pageExtendedBackgroundColor());
> 
> This should be done in WebPageProxy::didCommitLayerTree().
> 

Moved.

> > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:342
> > +        if ([self _backgroundExtendsBeyondPage] && pageExtendedBackgroundColor != [_scrollView backgroundColor])
> 
> You may not need pageExtendedBackgroundColor != [_scrollView backgroundColor], UIScrollView might do that already.
> 

Okay, I will remove it if it's not needed.

> > Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:880
> > +    if (m_page->drawingArea())
> > +        m_page->drawingArea()->scheduleCompositingLayerFlush();
> 
> Do we really need this? I would think a flush must be scheduled already since the style would invalidate the full frame rect.

It's true that in my testing it doesn't seem like we need to do anything here…

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.