[Webkit-unassigned] [Bug 103473] [CSS Grid Layout] Make sure grid element's shrink-to-fit behavior is correct

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 10 05:03:41 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=103473





--- Comment #6 from Sergio Villar Senin <svillar at igalia.com>  2014-03-10 05:00:37 PST ---
(From update of attachment 226176)
View in context: https://bugs.webkit.org/attachment.cgi?id=226176&action=review

Looks good to me, but I'd prefer Hyatt or any other rendering expert to take a look at it.

> LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit-expected.txt:3
> +The following grids should be 400px * 400px, except the first one which uses 'relative' positioning.

This comment looks weird because we don't print any size information.

> LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html:56
> +<p>The following grids should be 400px * 400px, except the first one which uses 'relative' positioning.</p>

See comment in -expected.txt

> LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html:58
> +<div class="grid" id="regularGrid" data-expected-height="400" data-expected-width="769">

The value for the width may differ depending on the platform because it's the width of the DRT viewport. Better set a fixed size for <body> (like 800x600) and use that value here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list